github: Fix internal problem matcher for color ASCII escape codes #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal warnings/errors problem matcher regex still does not highlight the messages properly, even though I tested the regex. Unfortunately, the reason is only obvious when looking at the raw GitHub logs, which shows the raw color ASCII escape codes that print_red() and print_yellow() use. Add the escape codes to the regex to fix the matching, which ends up making the matcher more robust because it will only highlight the color messages that the script generates. Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
requested review from
JustinStitt,
bwendling and
nickdesaulniers
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal warnings/errors problem matcher regex still does not highlight the messages properly, even though I tested the regex. Unfortunately, the reason is only obvious when looking at the raw GitHublogs, which shows the raw color ASCII escape codes that
print_red()andprint_yellow()use.Add the escape codes to the regex to fix the matching, which ends up making the matcher more robust because it will only highlight the color messages that the script generates.